Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Handle empty service config better #423

Merged
merged 4 commits into from Jun 23, 2020
Merged

Handle empty service config better #423

merged 4 commits into from Jun 23, 2020

Conversation

loosebazooka
Copy link
Contributor

@loosebazooka loosebazooka commented Jun 20, 2020

fixes the error message for non appengine-web.xml projects when not specifying a service.

#421 (comment)

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #423 into master will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #423      +/-   ##
============================================
+ Coverage     58.94%   59.50%   +0.55%     
- Complexity      117      120       +3     
============================================
  Files            32       32              
  Lines           643      642       -1     
  Branches         49       50       +1     
============================================
+ Hits            379      382       +3     
+ Misses          247      244       -3     
+ Partials         17       16       -1     
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/tools/maven/run/AbstractRunMojo.java 42.85% <100.00%> (+34.52%) 4.00 <3.00> (+3.00)
.../java/com/google/cloud/tools/maven/run/Runner.java 75.43% <100.00%> (+0.43%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fe3b6...8eb72fa. Read the comment docs.

Copy link
Contributor

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a code format issue.

@loosebazooka loosebazooka merged commit 32f4c6c into master Jun 23, 2020
@loosebazooka loosebazooka deleted the devappserver-error branch June 23, 2020 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants