Upgrade GKE package to kpt v1 #40
Conversation
| # The project in which to manage cluster resources | ||
| platform-project-id: platform-project-id # kpt-set: ${platform-project-id} | ||
| # The namespace in which to manage service enablement resources | ||
| projects-namespace: projects # kpt-set: ${projects-namespace} |
There was a problem hiding this comment.
We should move shared setters to the top-level package. The way it's currently set up you'll have to update the value in each subpackage.
There was a problem hiding this comment.
I tested it. It works as-is.
The inner pipelines run before the outer pipelines, which means inner values only matter for setters that aren't in the outer values.
I filed a FR to provide what I think would be more intuitive behavior: kptdev/kpt#2385
There was a problem hiding this comment.
I see. That's definitely not intuitive but we don't need to block on it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, morgante The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
No description provided.