fix: handle context cancellations during instance refresh

[jault3]

Change Description

Context cancellation was being checked after the immediate retries for errored instance refreshes. This moves the check up a bit further so the background refresh process exits once the context is cancelled.

Checklist

• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea.
• Ensure the tests and linter pass
• Appropriate documentation is updated (if necessary)

Relevant issues:

• Fixes Context cancellation ignored causing heavy CPU usage #370

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[enocom]

@jault3 If sign the CLA, we can get to this quickly.

[jault3]

@jault3 If sign the CLA, we can get to this quickly.

👍 apologies for the delay. Trying to track this down on my side. I believe my employer has something set up that I need added to. Will post back once I have it sorted out.

[jault3]

@jault3 If sign the CLA, we can get to this quickly.

Hey @enocom I believe I have things signed now. Looks like the CLA check is still failing though. Do I need to do anything else? It should be signed by my employer

[enocom]

You'll have to update the commit to include whatever email you used to sign the CLA, I believe. I forced a re-scan and it's still not happy.

[jault3]

Do the commits have to use the email address of the Authorized Contributors Group? Because I am a member of that group I submitted in that field. And the email I used in my commits (and shown in the CLA output) is the correct one. But its just my email address, not the group address.

[jault3]

I was reading this page and it looks like it mentions that corporate contributors may take a couple days to process. We may be stuck in that period as it was just signed today.

[enocom]

I'll check my end to see what we can do.

[jault3]

@enocom it is now signed!

[enocom]

Thanks @jault3!