-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle context cancellations during instance refresh #372
fix: handle context cancellations during instance refresh #372
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@jault3 If sign the CLA, we can get to this quickly. |
👍 apologies for the delay. Trying to track this down on my side. I believe my employer has something set up that I need added to. Will post back once I have it sorted out. |
move check for context completion higher up moved successful refresh handling back after error checking
56dcf49
to
6a8e061
Compare
You'll have to update the commit to include whatever email you used to sign the CLA, I believe. I forced a re-scan and it's still not happy. |
Do the commits have to use the email address of the |
I was reading this page and it looks like it mentions that corporate contributors may take a couple days to process. We may be stuck in that period as it was just signed today. |
I'll check my end to see what we can do. |
@enocom it is now signed! |
Thanks @jault3! |
Change Description
Context cancellation was being checked after the immediate retries for errored instance refreshes. This moves the check up a bit further so the background refresh process exits once the context is cancelled.
Checklist
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea.
Relevant issues: