fix: prevent repeated context expired errors #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go Connector uses a rate limiter to prevent excessive API usage. When refresh attempts failed a few times, however, the Go Connector would continue to schedule new attempts which would be rate limited. The rate limited error would then result in another refresh attempt being scheduled. As a result, the Go Connector would report numerous "context deadline expired" errors which were in fact rate limiting errors. This commit moves the rate limiter to the entry point of the refresh code. This change ensures that if there are refresh failures, there are not runaway attempts to refresh again. Instead, when an error occurs, a new refresh attempt will run only once the rate limiter allows it to run.
jackwotherspoon
approved these changes
Feb 14, 2023
The timeout should be greater than the interval enforced by the rate limiter to ensure there is time left over after being rate limited to complete a refresh cycle.
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
Feb 15, 2023
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go Connector uses a rate limiter to prevent excessive API usage. When refresh attempts failed a few times, however, the Go Connector would continue to schedule new attempts which would be rate limited. The rate limited error would then result in another refresh attempt being scheduled. As a result, the Go Connector would report numerous "context deadline expired" errors which were in fact rate limiting errors.
This commit moves the rate limiter to the entry point of the refresh code. This change ensures that if there are refresh failures, there are not runaway attempts to refresh again. Instead, when an error occurs, a new refresh attempt will run only once the rate limiter allows it to run.
Fixes #384