Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add connection name to public API #698

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat: add connection name to public API #698

merged 1 commit into from
Dec 15, 2023

Conversation

enocom
Copy link
Member

@enocom enocom commented Dec 15, 2023 •
edited

Fixes #320

@enocom enocom requested a review from a team as a code owner December 15, 2023 17:46
jackwotherspoon
jackwotherspoon approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enocom enocom merged commit 84f3b6e into main Dec 15, 2023
13 checks passed
@enocom enocom deleted the export-conn-name branch December 15, 2023 17:57
@release-please release-please bot mentioned this pull request Dec 15, 2023
Merged
@enocom enocom mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export instance connection name parsing
2 participants
@enocom @jackwotherspoon