Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalidate cache on failed Warmup and EngineVersion #827

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Jun 6, 2024

Invalidate the cache and stop background refreshes on failed Warmup and EngineVersion calls.

Fixes #778

@jackwotherspoon jackwotherspoon self-assigned this Jun 6, 2024
@jackwotherspoon jackwotherspoon changed the title fix: invalidate cache on failed warmup and EngineVersion fix: invalidate cache on failed Warmup and EngineVersion Jun 6, 2024
@jackwotherspoon jackwotherspoon marked this pull request as ready for review June 11, 2024 18:13
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner June 11, 2024 18:13
dialer.go Show resolved Hide resolved
@jackwotherspoon jackwotherspoon merged commit c3915a6 into main Jun 12, 2024
13 checks passed
@jackwotherspoon jackwotherspoon deleted the invalidate-cache-on-lookup branch June 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warmup and EngineVersion don't close cache on failed lookup
2 participants