From bdcab1d4dab412eb2843c1f3831b504c4d42173f Mon Sep 17 00:00:00 2001 From: Jonathan Hess Date: Wed, 19 Jul 2023 14:05:04 -0600 Subject: [PATCH] chore: make rate clearer. --- .../com/google/cloud/sql/core/CoreSocketFactory.java | 2 +- .../google/cloud/sql/core/CloudSqlInstanceTest.java | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java b/core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java index e9cc11ea4..2715ee59a 100644 --- a/core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java +++ b/core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java @@ -358,6 +358,6 @@ CloudSqlInstance getCloudSqlInstance(String instanceName, AuthType authType) { credentialFactory, executor, localKeyPair, - RateLimiter.create(2.0 / 60.0))); // 2 refresh attempts per minute + RateLimiter.create(1.0 / 30.0))); // 1 refresh attempt every 30 seconds } } diff --git a/core/src/test/java/com/google/cloud/sql/core/CloudSqlInstanceTest.java b/core/src/test/java/com/google/cloud/sql/core/CloudSqlInstanceTest.java index 2ee24fc3f..5831e5407 100644 --- a/core/src/test/java/com/google/cloud/sql/core/CloudSqlInstanceTest.java +++ b/core/src/test/java/com/google/cloud/sql/core/CloudSqlInstanceTest.java @@ -76,7 +76,7 @@ public void testCloudSqlInstanceDataRetrievedSuccessfully() throws Exception { stubCredentialFactory, executorService, keyPairFuture, - RateLimiter.create(2.0 / 60.0)); + RateLimiter.create(1.0 / 30.0)); SslData gotSslData = instance.getSslData(); assertThat(gotSslData).isSameInstanceAs(instanceDataSupplier.response.getSslData()); @@ -110,7 +110,7 @@ public void testInstanceFailsOnConnectionError() throws Exception { stubCredentialFactory, executorService, keyPairFuture, - RateLimiter.create(2.0 / 60.0)); + RateLimiter.create(1.0 / 30.0)); RuntimeException ex = Assert.assertThrows(RuntimeException.class, instance::getSslData); assertThat(ex).hasMessageThat().contains("always fails"); @@ -138,7 +138,7 @@ public void testCloudSqlInstanceForcesRefresh() throws Exception { stubCredentialFactory, executorService, keyPairFuture, - RateLimiter.create(2.0 / 60.0)); + RateLimiter.create(1.0 / 30.0)); SslData gotSslData = instance.getSslData(); assertThat(gotSslData).isSameInstanceAs(sslData); @@ -178,7 +178,7 @@ public void testGetPreferredIpTypes() throws Exception { stubCredentialFactory, executorService, keyPairFuture, - RateLimiter.create(2.0 / 60.0)); + RateLimiter.create(1.0 / 30.0)); assertThat(instance.getPreferredIp(Arrays.asList("PUBLIC", "PRIVATE"))).isEqualTo("10.1.2.3"); assertThat(instance.getPreferredIp(Arrays.asList("PUBLIC"))).isEqualTo("10.1.2.3"); @@ -215,7 +215,7 @@ public void testGetPreferredIpTypesThrowsException() throws Exception { stubCredentialFactory, executorService, keyPairFuture, - RateLimiter.create(2.0 / 60.0)); + RateLimiter.create(1.0 / 30.0)); Assert.assertThrows( IllegalArgumentException.class, () -> instance.getPreferredIp(Arrays.asList("PRIVATE"))); }