Fix platform detection in case of FreeBSD in compat module. #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: For platform detection for Python >= 3.6 the
distropackage is used. For lower version of Python the built-in packageplatformis used.distro.linux_distribution()is used to detect Linuxdistro.version()is used to detecting FreeBSDMethod
distro.version()should not be used becausedistrocan be eitherdistroitself orimport platform as distro, therefore:platform.version()anddistro.version()return different values.platform.version()returns 'FreeBSD 11.2-RELEASE-p9.....'distro.version()returns '11.2'Solution: Do not detect platform and version (in case of FreeBSD) using
distropackage, which is useful for linux but it's not necessary for FreeBSD.