New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new sample for response streaming #2222
feat: Add new sample for response streaming #2222
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQuery.Tests.csproj
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQueryTest.cs
Outdated
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQueryTest.cs
Outdated
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQueryTest.cs
Outdated
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery/StreamBigQuery.csproj
Outdated
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQueryTest.cs
Outdated
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQueryTest.cs
Outdated
Show resolved
Hide resolved
functions/responsestreaming/StreamBigQuery.Tests/StreamBigQueryTest.cs
Outdated
Show resolved
Hide resolved
(Sorry for so many extra comments... with the solution in place, it was much easier for me to pull, review locally, test it myself etc.) |
Thanks @jskeet, just resolved all the comments. Let me know how this looks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final nit to address, and then @amanda-tarafa and I can squash and merge (to avoid the merge commits).
@jskeet done, thank you! |
No description provided.