Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new sample for response streaming #2222

Merged
merged 15 commits into from Jul 11, 2023

Conversation

janell-chen
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 31, 2023
@snippet-bot
Copy link

snippet-bot bot commented May 31, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

functions/responsestreaming/Function.cs Outdated Show resolved Hide resolved
functions/responsestreaming/Function.cs Outdated Show resolved Hide resolved
functions/responsestreaming/StreamBigQuery.csproj Outdated Show resolved Hide resolved
functions/responsestreaming/StreamBigQueryTest.cs Outdated Show resolved Hide resolved
functions/responsestreaming/StreamBigQueryTest.cs Outdated Show resolved Hide resolved
functions/responsestreaming/Function.cs Outdated Show resolved Hide resolved
functions/responsestreaming/Function.cs Outdated Show resolved Hide resolved
@janell-chen janell-chen changed the title Add new sample for response streaming feat: Add new sample for response streaming Jun 13, 2023
@jskeet
Copy link
Member

jskeet commented Jul 6, 2023

(Sorry for so many extra comments... with the solution in place, it was much easier for me to pull, review locally, test it myself etc.)

@janell-chen
Copy link
Contributor Author

Thanks @jskeet, just resolved all the comments. Let me know how this looks

Copy link
Member

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nit to address, and then @amanda-tarafa and I can squash and merge (to avoid the merge commits).

@janell-chen
Copy link
Contributor Author

@jskeet done, thank you!

@jskeet jskeet merged commit 46a96ed into GoogleCloudPlatform:main Jul 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants