Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Add project Liens to inventory #2011

Merged
merged 10 commits into from Sep 18, 2018
Merged

Add project Liens to inventory #2011

merged 10 commits into from Sep 18, 2018

Conversation

umairidris
Copy link
Collaborator

Partially fix #2010.

@umairidris umairidris changed the title Add project Liens for to inventory Add project Liens to inventory Sep 14, 2018
Copy link
Contributor

@dufton dufton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current files look good, but I think you also need to add Liens to tests/services/inventory/gcp_api_mocks.py and tests/services/inventory/test_data/mock_gcp_results.py.
Then if you run tests/services/model/importer/update_test_dbs.py it will regenerate tests/services/model/importer/test_data/forseti-test.db and should show liens in the gcp_inventory table.

@umairidris
Copy link
Collaborator Author

Added tests and regenerated db

Copy link
Contributor

@joecheuk joecheuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this, once Andrew's comment is resolved it's good to go!

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #2011 into dev will increase coverage by 0.06%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##              dev    #2011      +/-   ##
==========================================
+ Coverage   89.27%   89.33%   +0.06%     
==========================================
  Files         162      162              
  Lines       12177    12212      +35     
==========================================
+ Hits        10871    10910      +39     
+ Misses       1306     1302       -4
Impacted Files Coverage Δ
...oogle/cloud/forseti/services/inventory/base/gcp.py 95.11% <100%> (+0.06%) ⬆️
...cloud/forseti/services/inventory/base/resources.py 93.74% <100%> (+0.09%) ⬆️
google/cloud/forseti/common/gcp_type/resource.py 98.57% <100%> (+0.02%) ⬆️
.../cloud/forseti/services/model/importer/importer.py 91.96% <100%> (+0.09%) ⬆️
...d/forseti/common/gcp_api/cloud_resource_manager.py 98.64% <87.5%> (-0.87%) ⬇️
google/cloud/forseti/services/inventory/storage.py 86.29% <0%> (+0.31%) ⬆️
google/cloud/forseti/services/inventory/crawler.py 90.32% <0%> (+4.03%) ⬆️

2 similar comments
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #2011 into dev will increase coverage by 0.06%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##              dev    #2011      +/-   ##
==========================================
+ Coverage   89.27%   89.33%   +0.06%     
==========================================
  Files         162      162              
  Lines       12177    12212      +35     
==========================================
+ Hits        10871    10910      +39     
+ Misses       1306     1302       -4
Impacted Files Coverage Δ
...oogle/cloud/forseti/services/inventory/base/gcp.py 95.11% <100%> (+0.06%) ⬆️
...cloud/forseti/services/inventory/base/resources.py 93.74% <100%> (+0.09%) ⬆️
google/cloud/forseti/common/gcp_type/resource.py 98.57% <100%> (+0.02%) ⬆️
.../cloud/forseti/services/model/importer/importer.py 91.96% <100%> (+0.09%) ⬆️
...d/forseti/common/gcp_api/cloud_resource_manager.py 98.64% <87.5%> (-0.87%) ⬇️
google/cloud/forseti/services/inventory/storage.py 86.29% <0%> (+0.31%) ⬆️
google/cloud/forseti/services/inventory/crawler.py 90.32% <0%> (+4.03%) ⬆️

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #2011 into dev will increase coverage by 0.06%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##              dev    #2011      +/-   ##
==========================================
+ Coverage   89.27%   89.33%   +0.06%     
==========================================
  Files         162      162              
  Lines       12177    12212      +35     
==========================================
+ Hits        10871    10910      +39     
+ Misses       1306     1302       -4
Impacted Files Coverage Δ
...oogle/cloud/forseti/services/inventory/base/gcp.py 95.11% <100%> (+0.06%) ⬆️
...cloud/forseti/services/inventory/base/resources.py 93.74% <100%> (+0.09%) ⬆️
google/cloud/forseti/common/gcp_type/resource.py 98.57% <100%> (+0.02%) ⬆️
.../cloud/forseti/services/model/importer/importer.py 91.96% <100%> (+0.09%) ⬆️
...d/forseti/common/gcp_api/cloud_resource_manager.py 98.64% <87.5%> (-0.87%) ⬇️
google/cloud/forseti/services/inventory/storage.py 86.29% <0%> (+0.31%) ⬆️
google/cloud/forseti/services/inventory/crawler.py 90.32% <0%> (+4.03%) ⬆️

@joecheuk joecheuk merged commit a6a45cc into forseti-security:dev Sep 18, 2018
@umairidris umairidris deleted the pl-inventory branch September 24, 2018 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for project liens
6 participants