Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current files look good, but I think you also need to add Liens to tests/services/inventory/gcp_api_mocks.py and tests/services/inventory/test_data/mock_gcp_results.py.
Then if you run tests/services/model/importer/update_test_dbs.py it will regenerate tests/services/model/importer/test_data/forseti-test.db and should show liens in the gcp_inventory table.
Added tests and regenerated db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this, once Andrew's comment is resolved it's good to go!
Codecov Report
@@ Coverage Diff @@
## dev #2011 +/- ##
==========================================
+ Coverage 89.27% 89.33% +0.06%
==========================================
Files 162 162
Lines 12177 12212 +35
==========================================
+ Hits 10871 10910 +39
+ Misses 1306 1302 -4
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## dev #2011 +/- ##
==========================================
+ Coverage 89.27% 89.33% +0.06%
==========================================
Files 162 162
Lines 12177 12212 +35
==========================================
+ Hits 10871 10910 +39
+ Misses 1306 1302 -4
|
Codecov Report
@@ Coverage Diff @@
## dev #2011 +/- ##
==========================================
+ Coverage 89.27% 89.33% +0.06%
==========================================
Files 162 162
Lines 12177 12212 +35
==========================================
+ Hits 10871 10910 +39
+ Misses 1306 1302 -4
|
Partially fix #2010.