Globally Rename find_policy_violations() to find_violations() #2172
Conversation
I tested by executing the commands below on both dev and this new branch to compare the results. There is a small section where the order of the violations are swapped. I'd like to check for your input on whether this is an allowable difference. Please see attached for the csv file of the violation outputs.
|
confirmed that there are no difference after sorting. The violations before and after the renaming is identical (except for violation id and timestamp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for cleaning this up! Been looking forward to this for a long time! Just one nit about removing all the TODOs.
@@ -70,8 +70,7 @@ def build_rule_book(self, global_configs=None): | |||
self.rule_book = BigqueryRuleBook(self._load_rule_definitions()) | |||
|
|||
# TODO: The naming is confusing and needs to be fixed in all scanners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this TODO, since they will not apply anymore after you are done. :)
Can you please remove this everywhere else in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all #TODO items related to renaming are deleted. Please note that I deleted the #TODO items along with the \n line change at the end of each line. Because of this, the function definition in the next line appears to be changed in the comparison, but it is actually only moved one line up.
Hey Henry @blueandgold, another freshly cooked revision! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for cleaning this up!
#1634
Thanks for opening a Pull Request!
Here's a handy checklist to ensure your PR goes smoothly.
pylint --rcfile=pylintrc
passes.These guidelines and more can be found in our contributing guidelines.