Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

script for enabling service apis, roles #792

Merged
merged 3 commits into from Nov 10, 2017
Merged

script for enabling service apis, roles #792

merged 3 commits into from Nov 10, 2017

Conversation

carise
Copy link
Contributor

@carise carise commented Nov 10, 2017

Docs will be updated in a separate PR

The manual gcp and local setup makes the user copy and paste (and then edit) the gcloud command for each API and role. Also, there is the confusion of what to do when the user is not an org admin.

This script does the following:

  1. Assign the APIs (we pull the API list from the setup wizard)
  2. Based on whether user specifies an org id, folder id, or project id, assign the roles on that hierarchy level. (also pulls the roles list from the setup wizard)
  3. Also allows user to specify the type of member to assign the role for (user, group, service account). This allows the user some flexibility if they are installing locally (i.e. probably don't care to create a separate service account for development; we aren't even instructing the user how to activate the service account) or on GCP (in which case it makes sense to use the service account)

@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #792 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             dev    #792      +/-   ##
========================================
- Coverage   84.9%   84.9%   -0.01%     
========================================
  Files        171     169       -2     
  Lines       9078    9076       -2     
========================================
- Hits        7708    7706       -2     
  Misses      1370    1370
Impacted Files Coverage Δ
...ogle/cloud/security/notifier/pipelines/__init__.py
google/cloud/security/notifier/__init__.py

Copy link
Contributor

@blueandgold blueandgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! On the documentation, we still want to leave the the manual steps for folks who want to roll up sleeves and do their own configurations.

@carise carise merged commit 7f4264e into dev Nov 10, 2017
@carise carise deleted the setup-roles-apis branch November 10, 2017 16:48
carise added a commit that referenced this pull request Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants