Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure go.mod matches actual language level #1603

Merged
merged 4 commits into from Aug 3, 2020
Merged

fix: make sure go.mod matches actual language level #1603

merged 4 commits into from Aug 3, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jul 24, 2020

Fixes: #1602

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2020
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 24, 2020
@codyoss
Copy link
Member Author

codyoss commented Jul 24, 2020

Looks like there are some more in the other modules will, be adding more constraints as I find them

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 24, 2020
@codyoss codyoss requested a review from tbpg July 24, 2020 16:05
@codyoss codyoss changed the title fix: add build constraint to ensure 1.11 compatibility fix: make sure go.mod matches actual language level Jul 30, 2020
@tbpg tbpg merged commit 3523351 into GoogleCloudPlatform:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: code does not build with go1.11
2 participants