Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
getting-started/bookshelf: initial rewrite #951
Areas to review:
Summary of changes:
dmitshur left a comment
The package code feels small and comprehensive, without too many extra things at the same time (compared to before). Overall, this looks like a nice simplification and general direction to move in.
I don't see any major issue or things to point out.
One option that is perhaps worth considering (and maybe you already have considered it) is to factor out the two
However, I don't think it would neccessarily be better. It feels like it would be roughly the same, maybe slightly worse (because the implementation code is quite short and simple). So having it all in one package is good too.
I left minor comments for a few trivial things.