Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers to use generated ruby version. #1311

Merged
merged 1 commit into from Mar 2, 2017

Conversation

landrito
Copy link
Contributor

@landrito landrito commented Mar 2, 2017

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2017
Copy link
Contributor

@blowmage blowmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to release these gems again to get the updated header?

@bjwatson
Copy link

bjwatson commented Mar 2, 2017

We do, but I don't want to burn your cycles re-releasing them all right away, unless you think you can get it done in less than an hour.

Otherwise, just focus on updating Vision this week, and releasing NL as soon as the blocking issue has been resolved. The rest can be updated next week.

@blowmage
Copy link
Contributor

blowmage commented Mar 2, 2017

We will plan on releasing major version bumps for Vision and NL tomorrow, and minor bumps for all other GRPC-based gems to get this change. I will merge this as soon as the Vision V1.1 build completes.

@blowmage blowmage self-assigned this Mar 2, 2017
@blowmage blowmage merged commit 4209f03 into googleapis:master Mar 2, 2017
@blowmage
Copy link
Contributor

blowmage commented Mar 4, 2017

@bjwatson All GRPC-based gems were released with this change yesterday.

@bjwatson
Copy link

bjwatson commented Mar 5, 2017

Thanks, Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. gapic grpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants