Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger::Railtie doesn't stop Rails from starting up #1411

Merged
merged 1 commit into from Apr 7, 2017

Conversation

hxiong388
Copy link
Contributor

Correctly wrap the Google::Cloud::Debugger::Project instantiating code inside the condition check block.

[closes #1410]

@hxiong388 hxiong388 requested a review from dazuma April 7, 2017 21:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2017
@@ -58,19 +58,20 @@ class Railtie < ::Rails::Railtie
end

initializer "Stackdriver.Debugger" do |app|
debugger_config = Railtie.parse_rails_config config
if self.class.use_debugger? app.config
debugger_config = Railtie.parse_rails_config config

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dazuma dazuma merged commit b5c583a into googleapis:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger Railtie raises exception if project id missing
4 participants