Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat(handler): Detect gitlab repos #27
Open
Conversation
This comment has been minimized.
This comment has been minimized.
googlebot
commented
Dec 14, 2018
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
This comment has been minimized.
This comment has been minimized.
googlebot
commented
Dec 14, 2018
CLAs look good, thanks! |
davidnewhall
added a commit
to golift/turbovanityurls
that referenced
this pull request
Jul 18, 2019
davidnewhall
added a commit
to golift/turbovanityurls
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jamesjwarren commentedDec 14, 2018
Gitlab supports the same url structure as github but is not automatically detected, this adds support for auto-detecting gitlab repos and applying default url config.