From 93a38cf3949c3e3c8ce17634c84ef40bb5d24f4c Mon Sep 17 00:00:00 2001 From: Dilip Pednekar Date: Fri, 22 Jan 2021 17:43:58 -0500 Subject: [PATCH] Use respectful code (#1190) * Use respectful code * Address review comments --- CHANGES.md | 12 ++++++------ gslib/tests/testcase/integration_testcase.py | 4 ++-- test/.pylintrc_limited | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index d17a5867fb..7c25a81ed4 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -242,7 +242,7 @@ New Features ------------------ - Added HMAC key management for service accounts. This includes a new "hmac" command to create/get/list/update/delete HMAC keys on service accounts. - Currently, your project must be whitelisted for use with this new HMAC + Currently, your project must be added to the allowlist for use with this new HMAC functionality. This restriction will be lifted in the near future. Bug Fixes @@ -330,8 +330,8 @@ New features - Added Bucket Policy Only support to gsutil. This includes a new "bucketpolicyonly" command to get/set BPO on existing buckets, as well adding the ability to set BPO at bucket creation time with "mb -b". Currently, your - project must be whitelisted for use with the new BPO functionality. This - restriction will be lifted in the near future. + project must be added to the allowlist for use with the new BPO functionality. + This restriction will be lifted in the near future. Bug Fixes ------------------ @@ -373,8 +373,8 @@ Release 4.34 (release date: 2018-09-11) ======================================= New features ------------------ -- Added bucket lock support to gsutil. Currently, your project must be - whitelisted for use with the new bucket lock functionality. This restriction +- Added bucket lock support to gsutil. Currently, your project must be added to + the allowlist for use with the new bucket lock functionality. This restriction will be lifted in the near future. Bug Fixes @@ -715,7 +715,7 @@ New Features configuration file. - Added the iam commmand, which can be used to set IAM policies on Google Cloud Storage buckets and objects. This feature is currently in - alpha and requires a whitelist application to use it - see + alpha and requires a safelist application to use it - see "gsutil help iam" for details. - The hash command now supports retrieving hashes for cloud objects. diff --git a/gslib/tests/testcase/integration_testcase.py b/gslib/tests/testcase/integration_testcase.py index 493fac5dab..74f6625bc4 100644 --- a/gslib/tests/testcase/integration_testcase.py +++ b/gslib/tests/testcase/integration_testcase.py @@ -335,8 +335,8 @@ def ClearPOSIXMetadata(self, obj): def _ServiceAccountCredentialsPresent(self): # TODO: Currently, service accounts cannot be project owners (unless - # they are grandfathered). Unfortunately, setting a canned ACL other - # than project-private, the ACL that buckets get by default, removes + # they are exempted for legacy reasons). Unfortunately, setting a canned ACL + # other than project-private, the ACL that buckets get by default, removes # project-editors access from the bucket ACL. So any canned ACL that would # actually represent a change the bucket would also orphan the service # account's access to the bucket. If service accounts can be owners diff --git a/test/.pylintrc_limited b/test/.pylintrc_limited index 62f00f23a6..5a32608d6e 100644 --- a/test/.pylintrc_limited +++ b/test/.pylintrc_limited @@ -10,7 +10,7 @@ # Profiled execution. profile=no -# Add to the black list. It should be a base name, not a +# Add to the deny list. It should be a base name, not a # path. You may set this option multiple times. # NOTE: To ignore specific directories, use the helper script to run pylint. # It uses the `find` command's `-prune` action, and it's much easier to @@ -41,7 +41,7 @@ load-plugins= ################################## # TODO: Come back to this approach. We should probably enable error messages # one at a time, determining which ones are feasible to enable, and -# eventually switch to a blacklist strategy, running all of them except +# eventually switch to a denylist strategy, running all of them except # the ones we've determined aren't helpful. # disable=bad-option-value, # fixme, @@ -50,7 +50,7 @@ load-plugins= # locally-disabled # ################################## -# Whitelist strategy: +# Allowlist strategy: disable=all enable=abstract-class-instantiated, anomalous-backslash-in-string,