Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local user groups for OS Login users. #30

Merged
merged 1 commit into from
May 4, 2020

Conversation

illfelder
Copy link
Contributor

No description provided.

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illfelder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leaving the video group for GPU instances.
@illfelder illfelder changed the title Remove all local user groups for OS Login users. Remove local user groups for OS Login users. May 4, 2020
@zmarano
Copy link
Contributor

zmarano commented May 4, 2020

/lgtm

@google-oss-robot google-oss-robot merged commit 88f1ba8 into GoogleCloudPlatform:master May 4, 2020
@@ -267,7 +267,7 @@ modify_group_conf() {
fi

local group_config="${1:-${group_config}}"
local group_conf_entry="sshd;*;*;Al0000-2400;dip,plugdev,video"
local group_conf_entry="sshd;*;*;Al0000-2400;video"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why group 39(video) need to stay default? GCP have any use specific for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants