New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency region tags and update used region tags #1197

merged 2 commits into from Aug 29, 2018


None yet
5 participants

alixhami commented Aug 27, 2018

The goal with sample region tags is to have a globally unique tag for each sample. The "dependencies" tag is used throughout the java-docs-samples repo, which goes against best practices. This PR accomplishes the following:

  • For region tags that are not used on, remove the region tag
  • For region tags that are used on, add a prefix of product_java_ (ex. bigquery_java_dependencies)

Note that this PR does not include all products, only ones that I am responsible for adding to the sample tracker. Others will be performing this update for the remaining products.

@alixhami alixhami requested review from tswast and nnegrey Aug 27, 2018

@googlebot googlebot added the cla: yes label Aug 27, 2018


(interesting how some are used and others aren't)

@alixhami alixhami dismissed stale reviews from tswast and nnegrey via 97329cd Aug 28, 2018


This comment has been minimized.


alixhami commented Aug 28, 2018

I updated my approach with the unused region tags. Rather than deleting them, I gave them names that use the standard globally unique naming conventions, so that we avoid people adding the plain "dependencies" region tag in the future.

@alixhami alixhami changed the title from [Do not merge] Remove unused dependency region tags and update used region tags to Remove unused dependency region tags and update used region tags Aug 29, 2018

@alixhami alixhami removed the DO NOT MERGE label Aug 29, 2018

@tswast tswast merged commit a88e2ff into master Aug 29, 2018

1 of 2 checks passed

Kokoro CI Internal CI build failed
cla/google All necessary CLAs are signed

@alixhami alixhami deleted the update-dependency-tags branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment