feat: add functions_env_vars

[grant]

Adds devrel/samples/1063.

[kurtisvg]

Suggested change

	public class Env {
	public class EnviromentVariableExample {

[grant]

This suggested name is too verbose and not in line with other class names. It is not common to add Example to all the other examples. Looking at the other 3 languages, I've changed the name to EnvVars.

[kurtisvg]

Checking for any empty string doesn't actually verify that this function works - any non-null string will contain and empty string.

[grant]

I'm not sure how to set an env var in a test and tried doing so.
Do you know how to set an env var?

[kurtisvg]

Can you stub it with Mockito?

when(System.getenv("FOO")).thenReturn("someTestValue");

[grant]

It looks like I can't stub with Mockito.

Cannot mock/spy class java.lang.System Mockito cannot mock/spy because : - final class

Not sure what to do.

[kurtisvg]

Ok, it looks like we'll have to add an additional dependency to do this:

<dependency>
  <groupId>com.github.stefanbirkner</groupId>
  <artifactId>system-rules</artifactId>
  <version>1.19.0</version>
  <scope>test</scope>
</dependency>

import org.junit.contrib.java.lang.system.EnvironmentVariables;

public void EnvironmentVariablesTest {
  @Rule
  public final EnvironmentVariables environmentVariables
    = new EnvironmentVariables();

  @Test
  public void setEnvironmentVariable() {
    environmentVariables.set("name", "value");
    assertEquals("value", System.getenv("name"));
  }
}

Source: https://stackoverflow.com/a/35393623/9414803

[grant]

Not exactly sure what to do in terms of mocking System.getenv.

[grant]

Ok, it looks like we'll have to add an additional dependency to do this:

<dependency>
  <groupId>com.github.stefanbirkner</groupId>
  <artifactId>system-rules</artifactId>
  <version>1.19.0</version>
  <scope>test</scope>
</dependency>

import org.junit.contrib.java.lang.system.EnvironmentVariables;

public void EnvironmentVariablesTest {
  @Rule
  public final EnvironmentVariables environmentVariables
    = new EnvironmentVariables();

  @Test
  public void setEnvironmentVariable() {
    environmentVariables.set("name", "value");
    assertEquals("value", System.getenv("name"));
  }
}

Source: https://stackoverflow.com/a/35393623/9414803

Thanks for the tip and extensive suggestion to fix this. Tests are now logical and pass. (Getting some merge conflicts, but those should be trivial.)
PTAL.

[kurtisvg]

LGTM, pending tests passing

[grant]

@kurtisvg Please advise as to how to fix the Java 11 test. I don't have permission to see the errors and debug.

[kurtisvg]

@grant - You should be able to access the logs by clicking Details next to the test name, and then clicking on the failed test log. This repo uses resultstore, so it should be open to the public. If it's not please let me know so we can debug.

Here is what is says atm:

---

• testing functions/snippets

---

[ERROR] src/test/java/SnippetsTests.java:[52] (indentation) Indentation: '=' has incorrect indentation level 4, expected level should be 6.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default) on project functions-snippets: You have 1 Checkstyle violation. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Testing failed: Maven returned a non-zero exit code.

[grant]

@grant - You should be able to access the logs by clicking Details next to the test name, and then clicking on the failed test log. This repo uses resultstore, so it should be open to the public. If it's not please let me know so we can debug.

Oh, there's a bug where the Invocation Log tab shows an inaccurate state.

You just need to wait a few seconds until the 15k lines of logs download and then you can see the error. A bit frustrating.

I sent feedback using the feedback tool.