Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node status from "componentstatuses" call. #7735

Merged
merged 1 commit into from May 5, 2015

Conversation

fabioy
Copy link
Contributor

@fabioy fabioy commented May 4, 2015

The legacy "/validate" behavior remains unchanged.

This should fix issue #7092.

@@ -441,7 +441,7 @@ func (m *Master) init(c *Config) {
"persistentVolumeClaims": persistentVolumeClaimStorage,
"persistentVolumeClaims/status": persistentVolumeClaimStatusStorage,

"componentStatuses": componentstatus.NewStorage(func() map[string]apiserver.Server { return m.getServersToValidate(c) }),
"componentStatuses": componentstatus.NewStorage(func() map[string]apiserver.Server { return m.getServersToValidate(c, true) }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have these backwards. You want this URL to skip the nodes but you pass true as the param for "include nodes".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO'H. Updated it

@roberthbailey
Copy link
Contributor

/cc @bgrant0607 FYI.

@roberthbailey roberthbailey self-assigned this May 4, 2015
The legacy "/validate" behavior remains unchanged.
@roberthbailey
Copy link
Contributor

LGTM. Will merge on green.

@fabioy
Copy link
Contributor Author

fabioy commented May 4, 2015

Filed issue #7738 to remove the "/validate" at some point.

@bgrant0607
Copy link
Member

Thanks much. LGTM.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2015
@roberthbailey
Copy link
Contributor

Travis finally passed!

roberthbailey added a commit that referenced this pull request May 5, 2015
Remove node status from "componentstatuses" call.
@roberthbailey roberthbailey merged commit 72048a8 into kubernetes:master May 5, 2015
@fabioy fabioy deleted the yank-nodes-status.fix branch June 5, 2016 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants