New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove node status from "componentstatuses" call. #7735
Conversation
@@ -441,7 +441,7 @@ func (m *Master) init(c *Config) { | |||
"persistentVolumeClaims": persistentVolumeClaimStorage, | |||
"persistentVolumeClaims/status": persistentVolumeClaimStatusStorage, | |||
|
|||
"componentStatuses": componentstatus.NewStorage(func() map[string]apiserver.Server { return m.getServersToValidate(c) }), | |||
"componentStatuses": componentstatus.NewStorage(func() map[string]apiserver.Server { return m.getServersToValidate(c, true) }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have these backwards. You want this URL to skip the nodes but you pass true as the param for "include nodes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO'H. Updated it
/cc @bgrant0607 FYI. |
The legacy "/validate" behavior remains unchanged.
f7a60a9
to
1709cf0
Compare
LGTM. Will merge on green. |
Filed issue #7738 to remove the "/validate" at some point. |
Thanks much. LGTM. |
Travis finally passed! |
Remove node status from "componentstatuses" call.
The legacy "/validate" behavior remains unchanged.
This should fix issue #7092.