Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight Legacy Stackdriver and New Stackdriver for GKE in documentation #3018

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Highlight Legacy Stackdriver and New Stackdriver for GKE in documentation #3018

merged 2 commits into from
Jan 27, 2020

Conversation

pradeepbhadani
Copy link
Contributor

No description provided.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff
Terraform Beta: Diff

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 63e5d90.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1676
depends: hashicorp/terraform-provider-google#5484

slevenick
slevenick reviewed Jan 24, 2020
View reviewed changes
third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
@@ -221,7 +221,7 @@ region are guaranteed to support the same version.
Automatically send metrics from pods in the cluster to the Google Cloud Monitoring API.
VM metrics will be collected by Google Compute Engine regardless of this setting
Available options include
`monitoring.googleapis.com`, `monitoring.googleapis.com/kubernetes`, and `none`.
`monitoring.googleapis.com`(`Legacy Stackdriver`), `monitoring.googleapis.com/kubernetes`(`Stackdriver Kubernetes Engine Monitoring`), and `none`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`monitoring.googleapis.com`(`Legacy Stackdriver`), `monitoring.googleapis.com/kubernetes`(`Stackdriver Kubernetes Engine Monitoring`), and `none`.
`monitoring.googleapis.com` (Legacy Stackdriver), `monitoring.googleapis.com/kubernetes` (Stackdriver Kubernetes Engine Monitoring), and `none`.

I think this is more clear if the names of the logging endpoints are unquoted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
write logs to. Available options include `logging.googleapis.com`,
`logging.googleapis.com/kubernetes`, and `none`. Defaults to `logging.googleapis.com/kubernetes`
write logs to. Available options include `logging.googleapis.com`(`Legacy Stackdriver`),
`logging.googleapis.com/kubernetes`(`Stackdriver Kubernetes Engine Logging`), and `none`. Defaults to `logging.googleapis.com/kubernetes`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`logging.googleapis.com/kubernetes`(`Stackdriver Kubernetes Engine Logging`), and `none`. Defaults to `logging.googleapis.com/kubernetes`
`logging.googleapis.com/kubernetes` (Stackdriver Kubernetes Engine Logging), and `none`. Defaults to `logging.googleapis.com/kubernetes`

Copy link
Contributor Author

@pradeepbhadani pradeepbhadani Jan 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slevenick - updated as per comment.

third_party/terraform/website/docs/r/container_cluster.html.markdown Outdated
@@ -184,8 +184,8 @@ making the cluster VPC-native instead of routes-based. Structure is documented
below.

* `logging_service` - (Optional) The logging service that the cluster should
write logs to. Available options include `logging.googleapis.com`,
`logging.googleapis.com/kubernetes`, and `none`. Defaults to `logging.googleapis.com/kubernetes`
write logs to. Available options include `logging.googleapis.com`(`Legacy Stackdriver`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
write logs to. Available options include `logging.googleapis.com`(`Legacy Stackdriver`),
write logs to. Available options include `logging.googleapis.com` (Legacy Stackdriver),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff
Terraform Beta: Diff

@slevenick slevenick self-requested a review January 27, 2020 21:43
slevenick
slevenick approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

@slevenick slevenick merged commit bbc06b1 into GoogleCloudPlatform:master Jan 27, 2020
This was referenced Jan 27, 2020
Merged
Merged
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
@pradeepbhadani
Highlight Legacy Stackdriver and New Stackdriver for GKE in documenta…
df36be7 
…tion (GoogleCloudPlatform#3018)

* Highlight Legacy Stackdriver and New Stackdriver for GKE in documentation

* update formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
cla: yes community downstream-generated terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradeepbhadani @modular-magician @slevenick @googlebot