New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed two doc format #4742
fixed two doc format #4742
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184690" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceGoogleCloudRunService_basic|TestAccComputeHealthCheckDatasource_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceComputeLbIpRanges_basic|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleBillingAccount_byFullNameClosed|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byDisplayName|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleClientConfig_basic|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeImageFilter|TestAccDataSourceComputeImage|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceComputeNodeTypes_basic|TestAccDataSourceGoogleNetwork|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccComputeRegions_basic|TestAccInstanceTemplateDatasource_name|TestAccDataSourceComputeInstance_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceComputeRouter|TestAccDataSourceComputeSslCertificate|TestAccComputeZones_basic|TestAccDataSourceGoogleVpnGateway|TestAccDataSourceGoogleSubnetwork|TestAccContainerEngineVersions_basic|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccComputeZones_filter|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_byFullNameNotFound|TestAccDataSourceIAMRole|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleOrganization_byDomain|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleServiceAccountIdToken_basic|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccIapClient_Datasource_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotFound|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNoDisplayNameOrType|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGooglePubsubTopic_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184691" |
Tests failed during RECORDING mode: TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceGoogleCloudRunService_basic|TestAccComputeHealthCheckDatasource_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceDNSKeys_basic|TestAccDataSourceComputeLbIpRanges_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleBillingAccount_byDisplayName|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleClientConfig_basic|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byFullNameClosed|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceComputeImage|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceComputeImageFilter|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeNodeTypes_basic|TestAccComputeRegions_basic|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRouter|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeSslCertificate|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceGoogleVpnGateway|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccContainerClusterDatasource_zonal|TestAccComputeZones_filter|TestAccContainerClusterDatasource_regional|TestAccComputeZones_basic|TestAccContainerEngineVersions_basic|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolder_byFullNameNotFound|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceIAMRole|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleOrganization_byDomain|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccIapClient_Datasource_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNoDisplayNameOrType|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotFound|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique|TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubTopic_optionalProject Please fix these to complete your PR |
Any idea what's up with these tests @edwardmedia? Doesn't make much sense to me why they're failing. |
/gcbrun to re-run tests |
Fixes hashicorp/terraform-provider-google#9015
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)