Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed two doc format #4742

Merged
merged 1 commit into from Jul 27, 2021
Merged

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Apr 28, 2021

Fixes hashicorp/terraform-provider-google#9015

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
Ansible: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184690"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceGoogleCloudRunService_basic|TestAccComputeHealthCheckDatasource_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceDNSKeys_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceComputeLbIpRanges_basic|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleBillingAccount_byFullNameClosed|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byDisplayName|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleClientConfig_basic|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeImageFilter|TestAccDataSourceComputeImage|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceComputeNodeTypes_basic|TestAccDataSourceGoogleNetwork|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccComputeRegions_basic|TestAccInstanceTemplateDatasource_name|TestAccDataSourceComputeInstance_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceComputeRouter|TestAccDataSourceComputeSslCertificate|TestAccComputeZones_basic|TestAccDataSourceGoogleVpnGateway|TestAccDataSourceGoogleSubnetwork|TestAccContainerEngineVersions_basic|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccComputeZones_filter|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_byFullNameNotFound|TestAccDataSourceIAMRole|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleOrganization_byDomain|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleServiceAccountIdToken_basic|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccIapClient_Datasource_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotFound|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNoDisplayNameOrType|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGooglePubsubTopic_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184691"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceGoogleCloudRunService_basic|TestAccComputeHealthCheckDatasource_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceDNSKeys_basic|TestAccDataSourceComputeLbIpRanges_basic|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleBillingAccount_byDisplayName|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleClientConfig_basic|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byFullNameClosed|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceComputeImage|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceComputeImageFilter|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceGoogleNetwork|TestAccDataSourceComputeNodeTypes_basic|TestAccComputeRegions_basic|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRouter|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeSslCertificate|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceGoogleVpnGateway|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccContainerClusterDatasource_zonal|TestAccComputeZones_filter|TestAccContainerClusterDatasource_regional|TestAccComputeZones_basic|TestAccContainerEngineVersions_basic|TestAccContainerEngineVersions_filtered|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolder_byFullNameNotFound|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceIAMRole|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleNetblockIpRanges_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleOrganization_byDomain|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccDataSourceGoogleServiceAccountIdToken_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccIapClient_Datasource_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNoDisplayNameOrType|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotFound|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGoogleMonitoringNotificationChannel_ErrorNotUnique|TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubTopic_optionalProject Please fix these to complete your PR

@rileykarson
Copy link
Member

Any idea what's up with these tests @edwardmedia? Doesn't make much sense to me why they're failing.

@edwardmedia edwardmedia requested review from melinath and removed request for rileykarson June 11, 2021 18:38
@melinath
Copy link
Member

/gcbrun to re-run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants