Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing golang Dockerfiles to work with skaffold debug #558

Merged
merged 1 commit into from Jun 17, 2021

Conversation

j-windsor
Copy link
Contributor

Fixes #556.

Change summary:

  • Allow skaffold to pass in go build flags
  • Set environment variable skaffold looks for to detect go debug environment
  • cleanup of the workdir for consistency in pathmapping.

Remaining issues / concerns:

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2021
@kelsk
Copy link
Contributor

kelsk commented Jun 17, 2021

@GoogleCloudPlatform/anthos-dpe PTAL - These changes help enable debugging the microservices demo using skaffold, Cloud Code, and Cloud Shell Editor.

Copy link
Contributor

@askmeegs askmeegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally; LGTM;

@askmeegs askmeegs merged commit 8a1d20a into GoogleCloudPlatform:master Jun 17, 2021
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go services are not ready for dlv or skaffold debugging
4 participants