Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run/hello-broken Test Fails #1817

Closed
grant opened this issue May 20, 2020 · 3 comments · Fixed by #1835
Closed

run/hello-broken Test Fails #1817

grant opened this issue May 20, 2020 · 3 comments · Fixed by #1835
Assignees
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@grant
Copy link
Contributor

grant commented May 20, 2020

The run/hello-broken tests fail on master.

This failure makes this PRs's test fail: #1809

I'm not sure what's going on and don't have access to logs. It makes changes to unrelated PRs fail.

CC: @grayside

@fhinkel
Copy link
Contributor

fhinkel commented May 20, 2020

👋 Hi @grant Thanks for opening an issue. We are aware that those tests are failing. It is explicitely called out in the contributor guide.

The logs are public. If you can't access them, can you please file a bug with Sponge. Thanks!

@fhinkel fhinkel closed this as completed May 20, 2020
@grayside
Copy link
Collaborator

Somehow, I was not aware this test was still failing. Opening to address. The problem is b/156023473.

@grayside grayside reopened this May 20, 2020
@grayside grayside self-assigned this May 20, 2020
@grayside grayside added api: run Issues related to the Cloud Run API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 20, 2020
@grant
Copy link
Contributor Author

grant commented May 20, 2020

Thanks for re-opening.

Even though this is a known issue by some people, I would still like to be able to track the state of the issue via some bug. I don't always re-check contribution guides before making PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants