Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests #284

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@fhinkel
Copy link
Member

fhinkel commented Feb 26, 2019

e2e tests send request against the live app living at
https://${opts.version}-dot-${opts.project}.appspot.com;

The test config relies on opts.project, which we configure via
an environment variable.

Note that only our tests use $GCLOUD_PROJECT, it is not used in the app.

Fix e2e tests
e2e tests send request against the live app living at
`https://${opts.version}-dot-${opts.project}.appspot.com`;

The test config relies on `opts.project`, which we configure via
an environment variable.

Note that only our tests use $GCLOUD_PROJECT, it is not used in the app.

@googlebot googlebot added the cla: yes label Feb 26, 2019

@fhinkel fhinkel requested a review from JustinBeckwith Feb 26, 2019

@fhinkel fhinkel merged commit 68b8afa into master Feb 26, 2019

4 checks passed

Internal CI (Cloud SQL) Tests passed!
Details
Internal CI (Datastore) Tests passed!
Details
Internal CI (MongoDB) Tests passed!
Details
cla/google All necessary CLAs are signed

@fhinkel fhinkel deleted the fixE2ETests branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.