Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available db regions #596

Merged
merged 1 commit into from Apr 13, 2018
Merged

Conversation

@miya0001
Copy link
Contributor

miya0001 commented Apr 12, 2018

If we run php wordpress-helper.php setup with the option like --db_region=asia-northeast1, the value of the region in app.yml and wp-config.php will be empty, because some regions are not defined.

This PR adds those regions to wordpress-helper.php.

@bshaffer bshaffer requested a review from tmatsuo Apr 12, 2018
Copy link
Member

tmatsuo left a comment

Thanks!

@tmatsuo

This comment has been minimized.

Copy link
Member

tmatsuo commented Apr 12, 2018

@dpebot Merge when green

@dpebot

This comment has been minimized.

Copy link
Collaborator

dpebot commented Apr 12, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

1 similar comment
@dpebot

This comment has been minimized.

Copy link
Collaborator

dpebot commented Apr 12, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge label Apr 12, 2018
@dpebot dpebot self-assigned this Apr 12, 2018
@bshaffer bshaffer merged commit fe32c07 into GoogleCloudPlatform:master Apr 13, 2018
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bshaffer

This comment has been minimized.

Copy link
Contributor

bshaffer commented Apr 13, 2018

Thank you for your contribution @miya0001 !!

@miya0001 miya0001 deleted the miya0001:add-regions branch Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.