Skip to content

Conversation

@riathakkar
Copy link
Contributor

@riathakkar riathakkar commented Aug 30, 2024

Description

Fixes b/362304568

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@riathakkar riathakkar requested review from a team as code owners August 30, 2024 20:21
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Aug 30, 2024
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2024
@riathakkar
Copy link
Contributor Author

How do we close this PR? @jinglundong

@jinglundong
Copy link
Contributor

I approved the PR. Let's wait for the Kokoro CI results.

@jinglundong
Copy link
Contributor

I just clicked re-run all checks to see if those Kokoro CI can be completed.

@jinglundong jinglundong requested a review from iennae September 19, 2024 20:20
@jinglundong
Copy link
Contributor

I don't know why the Kokoro CIs are not triggered. We may need approval from iennae, the other reviewer, as well.

@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 19, 2024
@jinglundong
Copy link
Contributor

3 tests/checks failed. Could you please take a look and ideally fix them? Thanks!

@riathakkar
Copy link
Contributor Author

@jinglundong I cant view the build results it says permisson denied. Im wondering if the linter is failing because its a js file with the python linter?

@riathakkar
Copy link
Contributor Author

@jinglundong I rerean the linter and it passes for some python.

nox > * py-2.7: failed
nox > * py-3.8: success
nox > * py-3.9: failed
nox > * py-3.10: failed
nox > * py-3.11: failed
nox > * py-3.12: success

What i dont understand is if the js file is ever going to pass a python linter? I dont know why this file is in this repository.

@jinglundong
Copy link
Contributor

jinglundong commented Sep 26, 2024

@kennethye1 At first glance, I was wondering if these integration tests failed due to the lifecycle policy enforcement. However, python-3.8 succeeded but python-3.11 failed. Are they really testing the modernized path?

Edit: seems like we are testing the modernized path. https://github.com/search?q=repo%3AGoogleCloudPlatform%2Fpython-docs-samples+ubuntu22&type=code, but we aren't really testing specific python minor versions from what I'm reading.

@jinglundong
Copy link
Contributor

@SandeepTuniki Could you help triage this PR?

@SandeepTuniki
Copy link

@SandeepTuniki Could you help triage this PR?

harisam@ is looking into this PR.

…leCloudPlatform#12673)

* Refactored "Text Generation" Category
* Refactored Text Generation files
* Moved openAI Samples
@riathakkar riathakkar requested review from a team and yuriatgoogle as code owners October 8, 2024 16:29
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 10, 2024
@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2024
@srinjoyray srinjoyray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 26, 2024
@chalmerlowe
Copy link
Contributor

Took a quick look at the build logs to see why these CI/CD checks are not passing.
Will discuss internally on b/362304568

@SandeepTuniki
Copy link

@riathakkar Perhaps we can close this PR now, since you raised another PR in #13022 and got it merged?

@riathakkar riathakkar closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.