-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Update poll.js to include XML Header in fetch request #12544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
How do we close this PR? @jinglundong |
|
I approved the PR. Let's wait for the Kokoro CI results. |
|
I just clicked re-run all checks to see if those Kokoro CI can be completed. |
|
I don't know why the Kokoro CIs are not triggered. We may need approval from iennae, the other reviewer, as well. |
|
3 tests/checks failed. Could you please take a look and ideally fix them? Thanks! |
|
@jinglundong I cant view the build results it says permisson denied. Im wondering if the linter is failing because its a js file with the python linter? |
|
@jinglundong I rerean the linter and it passes for some python. nox > * py-2.7: failed What i dont understand is if the js file is ever going to pass a python linter? I dont know why this file is in this repository. |
|
@kennethye1 At first glance, I was wondering if these integration tests failed due to the lifecycle policy enforcement. However, python-3.8 succeeded but python-3.11 failed. Are they really testing the modernized path? Edit: seems like we are testing the modernized path. https://github.com/search?q=repo%3AGoogleCloudPlatform%2Fpython-docs-samples+ubuntu22&type=code, but we aren't really testing specific python minor versions from what I'm reading. |
|
@SandeepTuniki Could you help triage this PR? |
harisam@ is looking into this PR. |
…leCloudPlatform#12673) * Refactored "Text Generation" Category * Refactored Text Generation files * Moved openAI Samples
|
Took a quick look at the build logs to see why these CI/CD checks are not passing. |
|
@riathakkar Perhaps we can close this PR now, since you raised another PR in #13022 and got it merged? |
Description
Fixes b/362304568
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)