From 9173c7b43ad9fe30bf2ca85e162769e13f53731b Mon Sep 17 00:00:00 2001 From: Adam Luong Date: Fri, 15 Nov 2024 16:30:18 -0500 Subject: [PATCH 1/3] feat: log the operation name to allow users to check the status --- managedkafka/snippets/clusters/create_cluster.py | 6 +++--- managedkafka/snippets/clusters/delete_cluster.py | 5 +++-- managedkafka/snippets/clusters/update_cluster.py | 6 ++++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/managedkafka/snippets/clusters/create_cluster.py b/managedkafka/snippets/clusters/create_cluster.py index da3abc8dcbe..e19eab3a9e1 100644 --- a/managedkafka/snippets/clusters/create_cluster.py +++ b/managedkafka/snippets/clusters/create_cluster.py @@ -71,10 +71,10 @@ def create_cluster( # The duration of this operation can vary considerably, typically taking 10-40 minutes. # We can set a timeout of 3000s (50 minutes). operation = client.create_cluster(request=request, timeout=3000) - print("Waiting for operation to finish...") + print(f"Waiting for operation {operation.operation.name} to complete...") response = operation.result() print("Created cluster:", response) - except GoogleAPICallError: - print("The operation failed with error:", operation.operation.error) + except GoogleAPICallError as e: + print(f"The operation failed with error: {e.message}") # [END managedkafka_create_cluster] diff --git a/managedkafka/snippets/clusters/delete_cluster.py b/managedkafka/snippets/clusters/delete_cluster.py index 52de575730d..342472ec36c 100644 --- a/managedkafka/snippets/clusters/delete_cluster.py +++ b/managedkafka/snippets/clusters/delete_cluster.py @@ -47,9 +47,10 @@ def delete_cluster( try: operation = client.delete_cluster(request=request) + print(f"Waiting for operation {operation.operation.name} to complete...") operation.result() print("Deleted cluster") - except GoogleAPICallError: - print("The operation failed with error:", operation.operation.error) + except GoogleAPICallError as e: + print(f"The operation failed with error: {e.message}") # [END managedkafka_delete_cluster] diff --git a/managedkafka/snippets/clusters/update_cluster.py b/managedkafka/snippets/clusters/update_cluster.py index 8bc946dd106..8f8e3f08e6f 100644 --- a/managedkafka/snippets/clusters/update_cluster.py +++ b/managedkafka/snippets/clusters/update_cluster.py @@ -56,9 +56,11 @@ def update_cluster( try: operation = client.update_cluster(request=request) + print(f"Waiting for operation {operation.operation.name} to complete...") + response = operation.result() print("Updated cluster:", response) - except GoogleAPICallError: - print("The operation failed with error:", operation.operation.error) + except GoogleAPICallError as e: + print(f"The operation failed with error: {e.message}") # [END managedkafka_update_cluster] From 9d1f707b56e7404f3aeb96c753c76b84cb735915 Mon Sep 17 00:00:00 2001 From: Adam Luong Date: Fri, 15 Nov 2024 16:31:48 -0500 Subject: [PATCH 2/3] remove blank line --- managedkafka/snippets/clusters/update_cluster.py | 1 - 1 file changed, 1 deletion(-) diff --git a/managedkafka/snippets/clusters/update_cluster.py b/managedkafka/snippets/clusters/update_cluster.py index 8f8e3f08e6f..9f741f489d3 100644 --- a/managedkafka/snippets/clusters/update_cluster.py +++ b/managedkafka/snippets/clusters/update_cluster.py @@ -57,7 +57,6 @@ def update_cluster( try: operation = client.update_cluster(request=request) print(f"Waiting for operation {operation.operation.name} to complete...") - response = operation.result() print("Updated cluster:", response) except GoogleAPICallError as e: From 184296135b81d3b6a7a7f62ee7f278ffc30a0d8d Mon Sep 17 00:00:00 2001 From: Adam Luong Date: Mon, 18 Nov 2024 11:59:29 -0500 Subject: [PATCH 3/3] Add timeout on operation polling level, not the client request --- managedkafka/snippets/clusters/create_cluster.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/managedkafka/snippets/clusters/create_cluster.py b/managedkafka/snippets/clusters/create_cluster.py index e19eab3a9e1..6de721a4081 100644 --- a/managedkafka/snippets/clusters/create_cluster.py +++ b/managedkafka/snippets/clusters/create_cluster.py @@ -68,11 +68,11 @@ def create_cluster( ) try: + operation = client.create_cluster(request=request) + print(f"Waiting for operation {operation.operation.name} to complete...") # The duration of this operation can vary considerably, typically taking 10-40 minutes. # We can set a timeout of 3000s (50 minutes). - operation = client.create_cluster(request=request, timeout=3000) - print(f"Waiting for operation {operation.operation.name} to complete...") - response = operation.result() + response = operation.result(timeout=3000) print("Created cluster:", response) except GoogleAPICallError as e: print(f"The operation failed with error: {e.message}")