Skip to content

Conversation

@eapl-gemugami
Copy link
Contributor

@eapl-gemugami eapl-gemugami commented Feb 4, 2025

Description

Fixes Internal:
b/347350844
b/347350275
b/347350679
b/347350796

Checklist

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Feb 4, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback in a few minutes. In the meantime, here's a summary of the changes for you and other reviewers to quickly get up to speed:

This pull request, authored by eapl-gemugami, aims to delete sample applications for XMPP, Mailjet, and Mailgun from the standard App Engine folder. The intent is likely to remove outdated or unnecessary samples, as indicated by the associated internal bug IDs (b/347350844, b/347350951, b/347350275, b/347350679) mentioned in the description.

Here's a breakdown of the changes:

  • Deleted Files:
    • appengine/standard/mailgun/.gitignore (entire file)
    • appengine/standard/mailgun/README.md (entire file)
    • appengine/standard/mailgun/app.yaml (entire file)
    • appengine/standard/mailgun/appengine_config.py (entire file)
    • appengine/standard/mailgun/main.py (entire file)
    • appengine/standard/mailgun/main_test.py (entire file)
    • appengine/standard/mailgun/requirements-test.txt (entire file)
    • appengine/standard/mailgun/requirements.txt (entire file)
    • appengine/standard/mailjet/.gitignore (entire file)
    • appengine/standard/mailjet/README.md (entire file)
    • appengine/standard/mailjet/app.yaml (entire file)
    • appengine/standard/mailjet/appengine_config.py (entire file)
    • appengine/standard/mailjet/main.py (entire file)
    • appengine/standard/mailjet/main_test.py (entire file)
    • appengine/standard/mailjet/requirements-test.txt (entire file)
    • appengine/standard/mailjet/requirements.txt (entire file)
    • appengine/standard/mailjet/templates/index.html (entire file)
    • appengine/standard/xmpp/README.md (entire file)
    • appengine/standard/xmpp/app.yaml (entire file)
    • appengine/standard/xmpp/requirements-test.txt (entire file)
    • appengine/standard/xmpp/requirements.txt (entire file)
    • appengine/standard/xmpp/xmpp.py (entire file)
    • appengine/standard/xmpp/xmpp_test.py (entire file)

The author has indicated that the PR should be merged upon approval.

Let me know if you have any questions.


And now for a little haiku to lighten the mood:

Code flows like a stream,
Deleting files, clean and swift,
PR ready to merge.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the outdated XMPP, Mailjet, and Mailgun samples from the appengine/standard directory. Removing outdated samples is good for repository maintainability. It simplifies the codebase and reduces confusion for users. I noticed that the samples for flexible environment are still present. Are these samples also outdated and need to be removed?

@eapl-gemugami eapl-gemugami changed the title chore(gae): delete samples xmpp, mailjet and mailgun in standard folder chore(gae): delete samples xmpp, mailjet, mailgun and pubsub in standard folder Feb 4, 2025
@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Feb 4, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Feb 4, 2025
@snippet-bot
Copy link

snippet-bot bot commented Feb 4, 2025

Here is the summary of changes.

You are about to delete 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@eapl-gemugami eapl-gemugami marked this pull request as ready for review February 4, 2025 20:13
@eapl-gemugami eapl-gemugami requested review from a team as code owners February 4, 2025 20:13
@iennae iennae merged commit 6088f72 into GoogleCloudPlatform:main Feb 5, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/gae/delete-samples/standard/xmpp-mailjet-and-mailgun branch February 5, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants