Skip to content

fix: use google_project_iam_member to manage IAM permissions #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2023
Merged

fix: use google_project_iam_member to manage IAM permissions #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d7ada5
fix: use google_project_iam_member to manage IAM permissions
grayside Apr 24, 2023
1b3b707
fix: members => member and split resources per sa
grayside Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions infra/iam.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,44 +48,59 @@ resource "google_service_account" "compute" {
count = var.init ? 1 : 0
}

# Both the server and Cloud Build can access the database
resource "google_project_iam_binding" "server_permissions" {
# The Cloud Run server can access the database
resource "google_project_iam_member" "server_permissions" {
project = var.project_id
role = "roles/cloudsql.client"
members = [local.server_SA, local.automation_SA]
depends_on = [google_service_account.server, google_service_account.automation]
member = local.server_SA
depends_on = [google_service_account.server]
}

# Cloud Build can access the database
resource "google_project_iam_member" "build_permissions" {
project = var.project_id
role = "roles/cloudsql.client"
member = local.automation_SA
depends_on = [google_service_account.automation]
}

# Server needs introspection permissions
resource "google_project_iam_binding" "server_introspection" {
resource "google_project_iam_member" "server_introspection" {
project = var.project_id
role = "roles/run.viewer"
member = local.server_SA
depends_on = [google_service_account.server]
}

# Client needs introspection permissions
resource "google_project_iam_member" "client_introspection" {
project = var.project_id
role = "roles/run.viewer"
members = [local.server_SA, local.client_SA]
depends_on = [google_service_account.server, google_service_account.client]
member = local.client_SA
depends_on = [google_service_account.client]
}

# Client may need permission to deploy the front end
resource "google_project_iam_binding" "client_permissions" {
resource "google_project_iam_member" "client_permissions" {
project = var.project_id
role = "roles/firebasehosting.admin"
members = [local.client_SA]
member = local.client_SA
depends_on = [google_service_account.client]
}

# GCE instance needs access to start Jobs
resource "google_project_iam_binding" "computestartup_permissions" {
resource "google_project_iam_member" "computestartup_permissions" {
project = var.project_id
role = "roles/run.developer"
members = ["serviceAccount:${google_service_account.compute[0].email}"]
member = "serviceAccount:${google_service_account.compute[0].email}"
depends_on = [google_service_account.compute]
count = var.init ? 1 : 0
}

# Server needs to write to Cloud Trace
resource "google_project_iam_binding" "server_traceagent" {
resource "google_project_iam_member" "server_traceagent" {
project = var.project_id
role = "roles/cloudtrace.agent"
members = [local.server_SA]
member = local.server_SA
depends_on = [google_service_account.server]
}