From 6c3bd0e042f21d392351bdd104760bc370e37a36 Mon Sep 17 00:00:00 2001 From: dstnluong-google <129889805+dstnluong-google@users.noreply.github.com> Date: Tue, 23 Apr 2024 14:22:17 -0700 Subject: [PATCH] Add uuid to reduce bucket name crashing (#2894) * Add uuid to notebooks. * Lint --- .../model_garden/model_garden_gemma_finetuning_on_vertex.ipynb | 3 ++- .../model_garden_pytorch_gemma_peft_finetuning_hf.ipynb | 3 ++- .../model_garden/model_garden_pytorch_llama2_deployment.ipynb | 3 ++- .../model_garden_pytorch_stable_diffusion_xl_1_0.ipynb | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/notebooks/community/model_garden/model_garden_gemma_finetuning_on_vertex.ipynb b/notebooks/community/model_garden/model_garden_gemma_finetuning_on_vertex.ipynb index 471cad3cb2..a5ff1732cb 100644 --- a/notebooks/community/model_garden/model_garden_gemma_finetuning_on_vertex.ipynb +++ b/notebooks/community/model_garden/model_garden_gemma_finetuning_on_vertex.ipynb @@ -100,6 +100,7 @@ "# @markdown **[Optional]** Set the GCS BUCKET_URI to store the experiment artifacts, if you want to use your own bucket. **If not set, a unique GCS bucket will be created automatically on your behalf**.\n", "\n", "import os\n", + "import uuid\n", "from datetime import datetime\n", "from typing import Tuple\n", "\n", @@ -118,7 +119,7 @@ "BUCKET_URI = \"gs://\" # @param {type:\"string\"}\n", "if not BUCKET_URI.strip() or BUCKET_URI == \"gs://\":\n", " # Create a unique GCS bucket for this notebook if not specified\n", - " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}\"\n", + " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}-{str(uuid.uuid4())[:4]}\"\n", " ! gsutil mb -l {REGION} {BUCKET_URI}\n", "assert BUCKET_URI.startswith(\"gs://\"), \"BUCKET_URI must start with `gs://`.\"\n", "\n", diff --git a/notebooks/community/model_garden/model_garden_pytorch_gemma_peft_finetuning_hf.ipynb b/notebooks/community/model_garden/model_garden_pytorch_gemma_peft_finetuning_hf.ipynb index 854cf51258..b48d560890 100644 --- a/notebooks/community/model_garden/model_garden_pytorch_gemma_peft_finetuning_hf.ipynb +++ b/notebooks/community/model_garden/model_garden_pytorch_gemma_peft_finetuning_hf.ipynb @@ -101,6 +101,7 @@ "\n", "import os\n", "import sys\n", + "import uuid\n", "from datetime import datetime\n", "from typing import Tuple\n", "\n", @@ -119,7 +120,7 @@ "BUCKET_URI = \"gs://\" # @param {type:\"string\"}\n", "if not BUCKET_URI.strip() or BUCKET_URI == \"gs://\":\n", " # Create a unique GCS bucket for this notebook if not specified\n", - " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}\"\n", + " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}-{str(uuid.uuid4())[:4]}\"\n", " ! gsutil mb -l {REGION} {BUCKET_URI}\n", "assert BUCKET_URI.startswith(\"gs://\"), \"BUCKET_URI must start with `gs://`.\"\n", "\n", diff --git a/notebooks/community/model_garden/model_garden_pytorch_llama2_deployment.ipynb b/notebooks/community/model_garden/model_garden_pytorch_llama2_deployment.ipynb index 2e82de3878..8000187718 100644 --- a/notebooks/community/model_garden/model_garden_pytorch_llama2_deployment.ipynb +++ b/notebooks/community/model_garden/model_garden_pytorch_llama2_deployment.ipynb @@ -97,6 +97,7 @@ "\n", "# Import the necessary packages\n", "import os\n", + "import uuid\n", "from datetime import datetime\n", "from typing import Tuple\n", "\n", @@ -119,7 +120,7 @@ "BUCKET_URI = \"gs://\" # @param {type:\"string\"}\n", "\n", "if BUCKET_URI is None or BUCKET_URI.strip() == \"\" or BUCKET_URI == \"gs://\":\n", - " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}\"\n", + " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}-{str(uuid.uuid4())[:4]}\"\n", " ! gsutil mb -l {REGION} {BUCKET_URI}\n", "else:\n", " assert BUCKET_URI.startswith(\"gs://\"), \"BUCKET_URI must start with `gs://`.\"\n", diff --git a/notebooks/community/model_garden/model_garden_pytorch_stable_diffusion_xl_1_0.ipynb b/notebooks/community/model_garden/model_garden_pytorch_stable_diffusion_xl_1_0.ipynb index cfcc911920..61cd098b01 100644 --- a/notebooks/community/model_garden/model_garden_pytorch_stable_diffusion_xl_1_0.ipynb +++ b/notebooks/community/model_garden/model_garden_pytorch_stable_diffusion_xl_1_0.ipynb @@ -98,6 +98,7 @@ "import base64\n", "import os\n", "import sys\n", + "import uuid\n", "from datetime import datetime\n", "from io import BytesIO\n", "\n", @@ -122,7 +123,7 @@ "\n", "# Create a unique GCS bucket for this notebook, if not specified by the user.\n", "if BUCKET_URI is None or BUCKET_URI.strip() == \"\" or BUCKET_URI == \"gs://\":\n", - " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}\"\n", + " BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}-{str(uuid.uuid4())[:4]}\"\n", " ! gsutil mb -l {REGION} {BUCKET_URI}\n", "else:\n", " BUCKET_NAME = \"/\".join(BUCKET_URI.split(\"/\")[:3])\n",