This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Report differences in mod time & file mod bits when diffing files #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This fixes #308 |
Author
|
I think reporting differences in the modification time should be made optional |
Author
|
Also, it seems when I test this, the reported mtime is the time the files were locally extracted at by container-diff instead of the mtime of the files in the images themselves |
Member
donmccasland
left a comment
donmccasland
left a comment
There was a problem hiding this comment.
Looks like integration tests are busted. I'll try to reproduce locally.
smukherj1
force-pushed
the
file-metadata-diff
branch
from
0e5f506 to
8d81093
Compare
Contributor
|
@smukherj1 is this PR still active? if so, can you try and get CI passing? |
Author
|
Yeah not really working on this anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to see if this change makes sense. If so, please let me know what tests I should add and where