Update JavaContainerBuilder for multiple dep layers #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadCordle
reviewed
Jun 12, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/api/JavaContainerBuilder.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JavaContainerBuilder.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JavaContainerBuilder.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jun 12, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/api/JavaContainerBuilder.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/tools/jib/plugins/common/JavaContainerBuilderHelper.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jun 12, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/api/JavaContainerBuilder.java
Outdated
Show resolved
Hide resolved
|
oh, I need to go fix the plugin tests. |
|
probably going to have to implement parts of the plugin stuff along with this fix :\ |
chanseokoh
approved these changes
Jun 13, 2019
TadCordle
approved these changes
Jun 13, 2019
chanseokoh
approved these changes
Jun 14, 2019
| @@ -6,6 +6,8 @@ All notable changes to this project will be documented in this file. | |||
| ### Added | |||
|
|
|||
| ### Changed | |||
| - `JibContainerBuilder#addDependencies` is now split into three methods: `addDependencies`, `addSnapshotDependencies`, `addProjectDependneices` ([#1773](https://github.com/GoogleContainerTools/jib/pull/1773)) | |||
|
|
|||
There was a problem hiding this comment.
Spelling error in "dependencies"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1724
This just redoes the previous behavior with a new API.
It does NOT cover: