Update status for all reconcile errors (#3960)

kptdev · May 12, 2023 · 2cbaaff · 2cbaaff
1 parent c544dff
commit 2cbaaff
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...lers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go b/...lers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
@@ -108,7 +108,8 @@ func (r *PackageVariantSetReconciler) Reconcile(ctx context.Context, req ctrl.Re
 			setStalledConditionsToTrue(pvs, "NoMatchingTargets", err.Error())
 			return ctrl.Result{}, nil
 		}
-		return ctrl.Result{}, err
+		setStalledConditionsToTrue(pvs, "UnexpectedError", err.Error())
+		return ctrl.Result{}, nil
 	}
 
 	meta.SetStatusCondition(&pvs.Status.Conditions, metav1.Condition{
@@ -120,7 +121,8 @@ func (r *PackageVariantSetReconciler) Reconcile(ctx context.Context, req ctrl.Re
 
 	err = r.ensurePackageVariants(ctx, pvs, repoList, upstreamPR, downstreams)
 	if err != nil {
-		return ctrl.Result{}, err
+		setStalledConditionsToTrue(pvs, "UnexpectedError", err.Error())
+		return ctrl.Result{}, nil
 	}
 
 	meta.SetStatusCondition(&pvs.Status.Conditions, metav1.Condition{