Add e2e tests for depends-on functionality #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droot
approved these changes
Jul 28, 2021
| return | ||
| } | ||
| t.Log("Applying resources in pre-apply directory") | ||
| cmd := exec.Command("kubectl", "apply", "-f", preApplyDir) |
There was a problem hiding this comment.
This is more of a note to self: It will be good to not depend on kubectl for just applying resources. kpt live apply should support this mode with a flag or something.
There was a problem hiding this comment.
Using kubectl here is useful, since it allows us to set up specific scenarios for testing that might be difficult to do using kpt itself.
|
Can be in a follow up PR, but we should have a test for destroy as well where the resources are deleted in reverse order. |
phanimarupaka
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds e2e tests to verify the
depends-onbehavior during apply and prune.