GcloudConfig as Default functionConfig data #2715
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
changed the title
bgrant0607
reviewed
Feb 2, 2022
Default configPath refers to gcloudConfig.yaml so users can have local gcloud config used as KRM function variants with best practice.
yuwenma
force-pushed
the
setter-free-demo
branch
from
51b3da8
to
dfa7af5
Compare
- Domain is fixed from gcloud core/account to the domain section in account - Make default config using fixed configMap meta name `gcloud-config` - Make default config using fixed file name `gcloud-config.yaml` - Do not set default ConfigPath in `kpt fn render`.
yuwenma
force-pushed
the
setter-free-demo
branch
from
a7fa510
to
f21b248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.