Implement PackageVariantSet v1alpha2 #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbelamaric
changed the title
|
I'd like this to start getting reviews. A few notes:
|
natasha41575
reviewed
May 2, 2023
porch/controllers/packagevariantsets/api/v1alpha2/packagevariantset_conversion.go
Outdated
Show resolved
Hide resolved
jpbetz
reviewed
May 3, 2023
porch/controllers/packagevariantsets/pkg/controllers/packagevariantset/render.go
Show resolved
Hide resolved
mortent
reviewed
May 3, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Outdated
Show resolved
Hide resolved
| for _, u := range uList.Items { | ||
| result = append(result, pvContext{ | ||
| template: target.Template, | ||
| repoDefault: u.GetName(), |
There was a problem hiding this comment.
If selectors matches arbitrary objects, is it still correct to use the name of the resource here?
There was a problem hiding this comment.
Yes; at least, that is how it is specified in the design :).
This is just the default. The user can override it using an expression based on the object (for example, target.annotations['repo-name']). That comes later in the PackageVariantTemplate.
johnbelamaric
force-pushed
the
pvs-v1alpha2
branch
from
00d3abe
to
b6ea267
Compare
|
Rebased |
natasha41575
reviewed
May 8, 2023
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Show resolved
Hide resolved
...rollers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go
Show resolved
Hide resolved
natasha41575
reviewed
May 9, 2023
There was a problem hiding this comment.
LGTM, but I think we should also get @mortent's approval on this one.
I appreciate the thorough unit tests btw!
mortent
approved these changes
May 10, 2023
jpbetz
reviewed
May 10, 2023
| | repoDefault | The default repository name based on the targeting criteria. | | ||
| | packageDefault | The default package name based on the targeting criteria. | | ||
| | upstream | The upstream PackageRevision. | | ||
| | repository | The downstream Repository. | |
There was a problem hiding this comment.
It's described in the paragraph below, because it's contented varies based on the type of target. But I will add it here in a follow up PR.
johnbelamaric
added a commit
to mortent/kpt
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the PackageVariantSet design described in https://github.com/GoogleContainerTools/kpt/blob/main/docs/design-docs/08-package-variant.md.