Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error messages when containers can’t be started #1415

Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 21, 2018

This is very useful, for example, to debug missing credentials.

Signed-off-by: David Gageot david@gageot.net

This is very useful, for example, to debug missing
credentials.

Signed-off-by: David Gageot <david@gageot.net>
@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #1415 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   44.65%   44.63%   -0.02%     
==========================================
  Files         111      111              
  Lines        4546     4548       +2     
==========================================
  Hits         2030     2030              
- Misses       2311     2313       +2     
  Partials      205      205
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 6.72% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e6a30...90babd2. Read the comment docs.

@balopat balopat merged commit 7e48e5d into GoogleContainerTools:master Dec 21, 2018
@dgageot dgageot deleted the error-container-waiting branch December 28, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants