Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for artifacts in cache in parallel #1799

merged 2 commits into from Mar 15, 2019


None yet
4 participants
Copy link

commented Mar 14, 2019

This PR checks for artifacts in the cache in parallel, continues work on #1740

On my desktop, with all cache hits, I noticed these speedups after adding this parallelization:

hipster shop microservices example (11 images)

with this PR:

Cache check complete in 800.688356ms
Cache check complete in 785.371388ms
Cache check complete in 820.054476ms

currently at HEAD:

Cache check complete in 5.104418923s
Cache check complete in 5.149867178s
Cache check complete in 5.250693574s

skaffold/examples/microservices (2 images)

with this PR:

Cache check complete in 507.760169ms
Cache check complete in 533.770901ms
Cache check complete in 497.994918ms

currently at HEAD:
Cache check complete in 1.004895467s
Cache check complete in 1.552249704s
Cache check complete in 1.12099431s

priyawadhwa added some commits Mar 14, 2019


This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

Merging #1799 into master will increase coverage by 0.04%.
The diff coverage is 82.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
+ Coverage   45.48%   45.53%   +0.04%     
  Files         142      142              
  Lines        6617     6626       +9     
+ Hits         3010     3017       +7     
- Misses       3306     3307       +1     
- Partials      301      302       +1
Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 86.33% <82.6%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58be2a...be409c7. Read the comment docs.

Copy link

left a comment

this is awesome!

@balopat balopat merged commit dd40af1 into GoogleContainerTools:master Mar 15, 2019

4 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
kokoro CI build successful.

@priyawadhwa priyawadhwa deleted the priyawadhwa:caching branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.