Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Wait Utils Into Watchers #1811

Merged
merged 2 commits into from Mar 22, 2019

Conversation

Projects
None yet
6 participants
@g-harel
Copy link
Contributor

commented Mar 15, 2019

#1170

This PR refactors wait utils into watchers.

I also updated WaitForDeploymentToStabilize to handle ctx.Done(). Behavior should otherwise not be affected.

@dgageot
Copy link
Member

left a comment

A few nits, otherwise LGTM!

Show resolved Hide resolved pkg/skaffold/kubernetes/wait.go Outdated
Show resolved Hide resolved pkg/skaffold/kubernetes/wait.go Outdated

@g-harel g-harel marked this pull request as ready for review Mar 17, 2019

@dgageot

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@g-harel can you fix the lint issue and rebase please?

@g-harel g-harel force-pushed the g-harel:wait-watchers branch 2 times, most recently from 016a4cd to 0b0c2fe Mar 19, 2019

g-harel added some commits Mar 15, 2019

@g-harel g-harel force-pushed the g-harel:wait-watchers branch from 0b0c2fe to 1862e63 Mar 19, 2019

@g-harel

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@dgageot done!

@codecov-io

This comment has been minimized.

Copy link

commented Mar 19, 2019

Codecov Report

Merging #1811 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   47.98%   47.83%   -0.16%     
==========================================
  Files         143      143              
  Lines        6483     6504      +21     
==========================================
  Hits         3111     3111              
- Misses       3089     3110      +21     
  Partials      283      283
Impacted Files Coverage Δ
pkg/skaffold/kubernetes/wait.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8418c9e...1862e63. Read the comment docs.

@dgageot dgageot merged commit 658b325 into GoogleContainerTools:master Mar 22, 2019

4 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.