Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for port forwarding key #2059

Merged
merged 1 commit into from May 2, 2019

Conversation

@priyawadhwa
Copy link
Member

priyawadhwa commented May 2, 2019

This should help make sure we don't add podname to the key again. Ref #1594.

This should help make sure we don't add podname to the key again. Ref #1594.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #2059 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2059   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files         179      179           
  Lines        7745     7745           
=======================================
  Hits         4342     4342           
  Misses       2987     2987           
  Partials      416      416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339edec...22bb0b9. Read the comment docs.

@tejal29
tejal29 approved these changes May 2, 2019
Copy link
Member

tejal29 left a comment

Thanks for the follow up!

@priyawadhwa priyawadhwa merged commit 2e65f9e into GoogleContainerTools:master May 2, 2019
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
@priyawadhwa priyawadhwa deleted the priyawadhwa:pftest branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.