Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain and make sure versions are pinned #2362

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@dgageot
Copy link
Member

dgageot commented Jun 27, 2019

Signed-off-by: David Gageot david@gageot.net

@googlebot googlebot added the cla: yes label Jun 27, 2019
@dgageot dgageot changed the title Update toolchain and make sure version are pinned Update toolchain and make sure versions are pinned Jun 27, 2019
@dgageot dgageot force-pushed the dgageot:integration-image branch from 0fefc15 to 8a9150b Jun 27, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #2362 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/jib/jib.go 77.41% <0%> (-1.08%) ⬇️
COPY --from=download-kompose kompose /usr/local/bin/
COPY --from=download-container-structure-test container-structure-test /usr/local/bin/
COPY --from=download-kind kind /usr/local/bin/
COPY --from=download-bazel /bazel /usr/local/bin/

This comment has been minimized.

Copy link
@balopat

balopat Jun 27, 2019

Collaborator

just to be consistent can this be bazel as well instead of /bazel or all the above /xyz?

This comment has been minimized.

Copy link
@balopat

balopat Jun 27, 2019

Collaborator

same for google-cloud-sdk

This comment has been minimized.

Copy link
@dgageot

dgageot Jun 27, 2019

Author Member

done!

@dgageot dgageot force-pushed the dgageot:integration-image branch from 8a9150b to 7ab5a57 Jun 27, 2019
@balopat

This comment has been minimized.

Copy link
Collaborator

balopat commented Jun 27, 2019

Thank you, I love the separate targets per download - hope to see this ran on buildkit one day being sped up in parallel!

COPY --from=download-kustomize kustomize /usr/local/bin/
COPY --from=download-kompose kompose /usr/local/bin/
COPY --from=download-container-structure-test container-structure-test /usr/local/bin/
COPY --from=download-kind kind /usr/local/bin/

This comment has been minimized.

Copy link
@balopat

balopat Jun 27, 2019

Collaborator

hold on don't we need kind only for integration? we shouldn't have it for runtime_deps

This comment has been minimized.

Copy link
@dgageot

dgageot Jun 27, 2019

Author Member

I thought it wouldn't hurt :-)

This comment has been minimized.

Copy link
@dgageot

dgageot Jun 27, 2019

Author Member

fixed!

This comment has been minimized.

Copy link
@balopat

balopat Jun 27, 2019

Collaborator

I guess it is an interesting option to have in the future. This structure allows for creating some nice "flavors" of skaffold, we could have kind included in them and that could solve provisioning clusters immediately with skaffold...which can be a pretty cool, one button setup: docker run -v $pwd:/app "--priviliged-and-daemon-mounted" gcr.io/k8s-skaffold/skaffold skaffold up that includes skaffold + kind in one go.

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the dgageot:integration-image branch from 7ab5a57 to 691e12d Jun 27, 2019
@balopat balopat merged commit 6bcaa54 into GoogleContainerTools:master Jun 27, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.