Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FakeAPIClient #2563

Merged
merged 1 commit into from Jul 29, 2019
Merged

Simplify FakeAPIClient #2563

merged 1 commit into from Jul 29, 2019

Conversation

@dgageot
Copy link
Member

dgageot commented Jul 29, 2019

Signed-off-by: David Gageot david@gageot.net

Copy link
Member

nkubala left a comment

looks fine, there's a lint issue with one of your error strings though

Signed-off-by: David Gageot <david@gageot.net>
@dgageot

This comment has been minimized.

Copy link
Member Author

dgageot commented Jul 29, 2019

Fixed!

@dgageot dgageot force-pushed the dgageot:fake-api branch from 2002001 to da0ff71 Jul 29, 2019
Copy link
Member

nkubala left a comment

LGTM assuming CI is green

@dgageot dgageot merged commit 4ba3d06 into GoogleContainerTools:master Jul 29, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.