Select resources by UUID label #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
balopat
reviewed
Aug 2, 2019
| ) | ||
|
|
||
| // DefaultLabeller adds K9 style managed-by label |
There was a problem hiding this comment.
hahaha, we had k9 style labels? 🐶
balopat
reviewed
Aug 2, 2019
balopat
reviewed
Aug 2, 2019
Codecov Report
|
tejal29
approved these changes
Aug 9, 2019
|
hey @corneliusweig this looks good, I think you just need to rebase! |
|
ping @corneliusweig, if you rebase we can merge! |
|
I'm still traveling, but I'll get to it by tomorrow evening. |
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
force-pushed
the
w/uuid-label
branch
from
2e02db0
to
591d813
Compare
Before, these were selected based on the managed-by label, which caused interferences in tests. Using the UUID label avoids these problems. Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
- use idiomatic go names - make sure the runID remains identical, even if multiple labeller instances are created Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
…he same runID Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
corneliusweig
force-pushed
the
w/uuid-label
branch
from
591d813
to
9a37620
Compare
|
@nkubala rebase is done! |
priyawadhwa
added
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details see #2496.
As described there, I added a new label which is specific to each skaffold run. When selecting resources, only resources created by the exact same skaffold run will be found.
Fixes #2496