Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`skaffold build` shouldn’t print the tags used in deployments #3091

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@dgageot
Copy link
Member

dgageot commented Oct 18, 2019

Fixes #3090

Also took the opportunity make the message about digests not being used for local deployments less intrusive. It's now shorter and shown in green instead of orange.

Signed-off-by: David Gageot david@gageot.net

Fixes #3090

Signed-off-by: David Gageot <david@gageot.net>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #3091 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
pkg/skaffold/runner/build_deploy.go 67.18% <ø> (+0.99%) ⬆️
pkg/skaffold/runner/deploy.go 66.66% <66.66%> (ø) ⬆️
@tejal29 tejal29 merged commit a0bfe56 into GoogleContainerTools:master Oct 18, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.