Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code style] Fix snake case import package "latest_v1" to "latestV1" #5799

Merged
merged 4 commits into from May 7, 2021

Conversation

yuwenma
Copy link
Collaborator

@yuwenma yuwenma commented May 6, 2021

No description provided.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like there are a few references that got missed, think they should all be pointed out in unit test failures

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #5799 (48b2012) into master (8efc9ef) will decrease coverage by 0.00%.
The diff coverage is 81.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5799      +/-   ##
==========================================
- Coverage   71.00%   71.00%   -0.01%     
==========================================
  Files         438      439       +1     
  Lines       16497    16493       -4     
==========================================
- Hits        11714    11711       -3     
  Misses       3921     3921              
+ Partials      862      861       -1     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/apply.go 25.00% <0.00%> (ø)
cmd/skaffold/app/cmd/delete.go 57.14% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 56.52% <0.00%> (ø)
cmd/skaffold/app/cmd/diagnose.go 64.51% <ø> (ø)
cmd/skaffold/app/cmd/filter.go 25.58% <0.00%> (ø)
cmd/skaffold/app/cmd/find_configs.go 48.48% <0.00%> (ø)
cmd/skaffold/app/cmd/generate_pipeline.go 61.53% <0.00%> (ø)
cmd/skaffold/app/cmd/render.go 40.74% <0.00%> (ø)
cmd/skaffold/app/cmd/runner.go 58.49% <0.00%> (ø)
cmd/skaffold/app/cmd/test.go 46.66% <0.00%> (ø)
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efc9ef...48b2012. Read the comment docs.

@tejal29 tejal29 added the kokoro:force-run forces a kokoro re-run on a PR label May 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 7, 2021
@tejal29 tejal29 dismissed MarlonGamez’s stale review May 7, 2021 20:43

addressed changes!

@tejal29 tejal29 enabled auto-merge (squash) May 7, 2021 20:43
@tejal29 tejal29 merged commit fb9c352 into GoogleContainerTools:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants