Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug in dirtyTag which may leave extra whitespaces in changedPath #721

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
3 participants
@neoseele
Copy link
Contributor

commented Jun 21, 2018

A git status --porcelain entry may have more one whitespaces between status character and the file path

-- snip --
DEBU[0000] Running command: [git status --porcelain]
DEBU[0000] Command output: stdout M containers/go/go-http/Dockerfile
A containers/go/go-http/k8s-deployment.yaml
A containers/go/go-http/kubernetes/deployment.yaml
AM containers/go/go-http/skaffold.yaml
, stderr:
FATA[0000] build step: generating tag: reading diff: open /Users/xxx/projs/gke/ containers/go/go-http/Dockerfile: no such file or directory

@dgageot dgageot merged commit 3d07bf2 into GoogleContainerTools:master Jun 22, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hypnoglow

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

Sadly, skaffold v0.8.0 is completely broken because of this bug ;(

@dgageot

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

@hypnoglow You might want to change the tagger to sha256 until a new release is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.