Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker build --cache-from #737

Merged
merged 2 commits into from Jun 25, 2018
Merged

Conversation

@dgageot
Copy link
Member

dgageot commented Jun 24, 2018

No description provided.

@dgageot dgageot requested review from dlorenc, r2d4 and viglesiasce as code owners Jun 24, 2018
@dgageot dgageot force-pushed the dgageot:cache-from branch 2 times, most recently from ccd81c0 to 9bf08ef Jun 24, 2018
dgageot added 2 commits Jun 24, 2018
Fixes #701

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the dgageot:cache-from branch from 9bf08ef to 536415f Jun 25, 2018
@balopat balopat self-assigned this Jun 25, 2018
Copy link
Collaborator

balopat left a comment

LGTM.

@balopat

This comment has been minimized.

Copy link
Collaborator

balopat commented Jun 25, 2018

I did think a little bit about keeping the BuildOptions around but I guess you're right to get rid of it - if there are skaffold specific image building options we can reintroduce a narrower interface + the output buffer really doesn't have to belong there.

@dgageot

This comment has been minimized.

Copy link
Member Author

dgageot commented Jun 25, 2018

@balopat Thanks for your time!

@dgageot dgageot merged commit e596794 into GoogleContainerTools:master Jun 25, 2018
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
@dgageot dgageot deleted the dgageot:cache-from branch Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.